Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed all @author tags from docblocks #3171

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Conversation

fballiano
Copy link
Contributor

The @author tag is used to document the author of Structural Elements as stated in https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/author.html#author

I think it shouldn't be considered as a copyright/license tag (that info is elsewhere) and since we (as in openmage contributors) do not add the author of every patch in the source code (it would be extremely overkill and git has the info anyway in the git blame) I think we can safely remove all of those tags.

Also, the email written in the removed tags is probably dead since years.

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: Cms Relates to Mage_Cms Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule JavaScript Relates to js/* Mage.php Relates to app/Mage.php shell Relates to shell scripts labels Apr 13, 2023
Copy link
Collaborator

@luigifab luigifab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script for copyright date will be happy.

@fballiano
Copy link
Contributor Author

Thanks for reminding me to check the squash comment (if it will be merged) not to screw with the copyright script!!

@fballiano fballiano merged commit 4e9520c into OpenMage:main Apr 13, 2023
@fballiano fballiano deleted the author branch April 13, 2023 21:20
seifer7 added a commit to seifer7/magento-lts that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api PageRelates to Mage_Api Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: Cms Relates to Mage_Cms Component: Contacts Relates to Mage_Contacts Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: GoogleAnalytics Relates to Mage_GoogleAnalytics Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule JavaScript Relates to js/* Mage.php Relates to app/Mage.php shell Relates to shell scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants