Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "object could not be converted to int" in Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Super_Config_Simple #3182

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

luigifab
Copy link
Collaborator

@luigifab luigifab commented Apr 16, 2023

Description

This PR fix Notice: Object of class Mage_Catalog_Model_Resource_Eav_Attribute could not be converted to int in app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Simple.php on line 70 when you go to Catalog > Products > Any configurable product.

PHP 8.0 & 8.2 (dev on).

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Apr 16, 2023
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

fballiano
fballiano previously approved these changes Apr 16, 2023
ADDISON74
ADDISON74 previously approved these changes Apr 16, 2023
Copy link
Contributor

@ADDISON74 ADDISON74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this issue. I applied this PR and no more warnings.

@fballiano fballiano changed the title Fix object could not be converted to int Fixed "object could not be converted to int" in Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Super_Config_Simple Apr 17, 2023
@fballiano fballiano merged commit 4ade428 into OpenMage:main Apr 17, 2023
@luigifab luigifab deleted the fix-notice-int branch April 18, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants