Removed PHPStan stubs #3210
Merged
Removed PHPStan stubs #3210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Captcha
ADDISON74
approved these changes
Apr 23, 2023
sreichel
reviewed
Apr 23, 2023
app/code/core/Mage/Eav/Model/Adminhtml/System/Config/Source/Inputtype/Validator.php
Show resolved
Hide resolved
luigifab
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A stub is a configuration file for PHPStan that overrides a specific docblock which resides in the vendor folder (which we don't have control on).
We've 2 stubs for PHPStan but I thought it could be a good idea to try to remove them, so I adapted our code to respect the (in this case) ZF1 docblock.
It seems to be working correctly, PHPStan is happy and we removed 2 "overrides".