Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed price expression SQL in layered navigation #3227

Merged
merged 1 commit into from
May 4, 2023
Merged

Fixed price expression SQL in layered navigation #3227

merged 1 commit into from
May 4, 2023

Conversation

elidrissidev
Copy link
Member

@elidrissidev elidrissidev commented May 2, 2023 •
edited
Loading

Description (*)

Another fix for an SQL expression that needed to be wrapped in a Zend_Db_Expr to prevent it from being incorrectly escaped.

Needs to be backported to v19.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes "Syntax error or access violation: 1064" when placing an order with 19.5.0-rc3 #3213

Manual testing scenarios (*)

  1. Go to System -> Configuration -> Tax -> Calculation Settings -> Catalog Prices and set it to "Including Tax"
  2. Go to the frontend and browse any Category, page should render properly and no exception is logged.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label May 2, 2023
fballiano
fballiano approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@fballiano
Copy link
Contributor

after this I'd like to have a -rc4 ;-)

@elidrissidev elidrissidev mentioned this pull request May 3, 2023
Closed
@fballiano fballiano merged commit 6166648 into OpenMage:main May 4, 2023
15 checks passed
@fballiano fballiano changed the title Fix price expression SQL in layered navigation Fixed price expression SQL in layered navigation May 4, 2023
@elidrissidev elidrissidev deleted the fix/catalog-price-tax-expr branch May 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@Sdfendor Sdfendor Sdfendor approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Syntax error or access violation: 1064" when placing an order with 19.5.0-rc3
4 participants
@elidrissidev @fballiano @Sdfendor @ADDISON74