Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed auto_detect_line_endings since it's deprecated in 8.1 #3282

Merged
merged 1 commit into from
May 29, 2023

Conversation

fballiano
Copy link
Contributor

In #3281 (comment) @TangLiang reported that auto_detect_line_endings is nowadays deprecated, more info about it here: https://php.watch/versions/8.1/auto_detect_line_endings-ini-deprecated

@elidrissidev
Copy link
Member

I would have just removed it altogether since \r is so ancient.

@fballiano
Copy link
Contributor Author

I thought of deleting it only in "next" with the other PR that I've posted, just to be safe, is it ok?

@elidrissidev
Copy link
Member

I thought of deleting it only in "next" with the other PR that I've posted, just to be safe, is it ok?

Yes

Note that auto_detect_line_endings directive only enables line-ending detection for \r characters, which are only used in legacy ("classic") Mac OS environments. It is not necessary to enable auto_detect_line_endings for PHP to detect standard \n and \r\n line-endings, which are common and used in Linux, Mac OS, and Windows systems.

@fballiano
Copy link
Contributor Author

oki :-)

@fballiano fballiano merged commit 4ea7dce into OpenMage:main May 29, 2023
15 checks passed
@fballiano fballiano deleted the auto_detect_line_endings1 branch May 29, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/*
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants