Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed display of products count for categories tree #3313

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fixed display of products count for categories tree #3313

merged 2 commits into from
Jun 12, 2023

Conversation

kyrena
Copy link
Contributor

@kyrena kyrena commented Jun 9, 2023 •
edited
Loading

Description

Go to Catalog > Products > Any product > Categories (default values).
You will found the root category name with products count.

If you change to any store view, without the PR you will found the root category name WITHOUT products count.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template labels Jun 9, 2023
@fballiano
Copy link
Contributor

can't test because of #3312

fballiano
fballiano approved these changes Jun 11, 2023
View reviewed changes
Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

elidrissidev
elidrissidev approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@elidrissidev elidrissidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@fballiano fballiano merged commit dc52061 into OpenMage:main Jun 12, 2023
3 checks passed
@kyrena kyrena deleted the productscount branch June 16, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@elidrissidev elidrissidev elidrissidev approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog Template : admin Relates to admin template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kyrena @fballiano @elidrissidev