Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info about v21 to the README #3388

Merged
merged 8 commits into from
Aug 18, 2023
Merged

Conversation

fballiano
Copy link
Contributor

No description provided.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ADDISON74
Copy link
Collaborator

It was absolutely necessary to keep a list of the differences between the main and next branches. You have certainly kept records and you can check if there are others. Those who use OM must be prepared for changes in the future, I think that very few use the next branch in testing. This list will help them.

@fballiano
Copy link
Contributor Author

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@fballiano fballiano requested a review from ADDISON74 July 17, 2023 20:36
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ADDISON74
ADDISON74 previously approved these changes Jul 17, 2023
@fballiano
Copy link
Contributor Author

that point is now the only one in the entire readme that has a ".", it doesn't look good to me, that's why I preferred one sentence. I don't think we've to say to backup, still.

@ADDISON74
Copy link
Collaborator

Often when things don't go well people tend to blame others. By mentioning to backup the files is the way to avoid further discussions.

@fballiano
Copy link
Contributor Author

it's written everywhere to backup when updating. anyway. I still think it looks off to have only one dot in the lists, but ok

@ADDISON74
Copy link
Collaborator

You can remove the last dot (after the "script" word) to keep the same format. All the others are fine.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ADDISON74
Copy link
Collaborator

Offtopic: #3146 - This merged PR should be in the main branch. It is a very useful feature. Moving a website to the next branch will involve effort. Jquery is 3.7 instead of 1.12, used in most existing extensions. this in addition to bringing extensions to PHP 8.2. Therefore, until the transition is made, certain PRs should be merged in the main branch, as is the one mentioned by me.

@fballiano
Copy link
Contributor Author

this one is already on the main branch, #3146 is a breaking change and since the famous RFC we've to put breaking changes in the next branch :-)

@fballiano fballiano merged commit f69f6fc into OpenMage:main Aug 18, 2023
1 check passed
@fballiano fballiano deleted the readmenext branch August 18, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants