Fixed unnecessary entries in table api-session when using insta-login in API calls
#3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in in API calls.
kiatng
commented
Aug 30, 2023
fballiano
reviewed
Aug 30, 2023
|
we can remove a line from the phpstan baseline in order to fix the workflow |
|
I don't understand why PHPStan is complaining the deleted function |
|
it says that we've to remove that line from the baseline, since it's not triggering an error anymore |
elidrissidev
reviewed
Sep 4, 2023
Co-authored-by: Mohamed ELIDRISSI <67818913+elidrissidev@users.noreply.github.com>
elidrissidev
approved these changes
Sep 5, 2023
fballiano
approved these changes
Sep 5, 2023
fballiano
changed the title
api-session when using insta-log…api-session when using insta-login in API calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in in API calls.
Description (*)
The API session has default expiry of 3600 secs from the time of the last API call. This expiry is managed in the table
api_asession. With the introduction of insta-login in PR #3443, the session expiry become irrelevant. This PR bypassed adding entries to the various api tables. In my test, this saves 10 to 20 mini-seconds to insta-login.Related Pull Requests
PR #3443
Fixed Issues (if relevant)
Partially fixed issue #3449.
Manual testing scenarios (*)
api_asessionwith insta-login.api_asessionwith "normal" login.