Backend: removed invalid "name" element, removed redundant nobr spans, added data-column-id to grids #3927
Conversation
… added data-column-id to grids
|
@loekvangool please check this one instead |
github-actions
bot
added
Template : admin
fballiano
changed the title
|
I'm getting aroused! Great stuff |
|
since I've tested this, I'll consider #3927 (comment) as a review and merge it tomorrow if nothing against comes up |
|
Okay since you insist I accept my promotion to committer |
| @@ -114,7 +114,7 @@ $numColumns = count($this->getColumns()); | |||
| <?php if ($this->getHeadersVisibility()): ?> | |||
| <tr class="headings"> | |||
| <?php foreach ($this->getColumns() as $_column): ?> | |||
| <th<?php echo $_column->getHeaderHtmlProperty() ?>><span class="nobr"><?php echo $_column->getHeaderHtml() ?></span></th> | |||
There was a problem hiding this comment.
Not sure about removing the span element. It may break custom styling that selects it, for example:
.grid tr.headings th span.nobr { ... }There was a problem hiding this comment.
It is true (I thought about it as I'm very strict with other changes like modifying the signature of a public method) but as the same time the possibility of this happening and the minor side effect made me go for it.
There was a problem hiding this comment.
we could merge this in v21 but... it seems overkill for this.
There was a problem hiding this comment.
also, I've just removed the .grid tr.headings th span.nobr CSS line which was a hack for firefox 3... firefox 3...
This PR rewrites #3923
In the process of reviewing #3923 I've seen that the
nameattribute is not valid forspanora, but the concept of the PR was interesting, so I did a clean up of the whole thing:thinsteadnobrspan (there are way too many DOM nodes in OM, they need to be simplified) and added awhite-space:nowrapto its container insteadCloses #3923