Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mage_Core - IDE improvements #682

Closed
wants to merge 4 commits into from
Closed

Mage_Core - IDE improvements #682

wants to merge 4 commits into from

Conversation

sreichel
Copy link
Contributor

  • added/fixed missing DOCs
  • add @method annotations
  • changed @return to $this for methods and annotations
  • changed magic methods on Varien_Objects to setData()/getData()
  • flipped @var annotations
  • ...

Mage_Customer - IDE improvements
e6a42d9 
- added/fixed missing DOCs
- add @method annotations
- changed @return to $this for methods and annotations
- changed magic methods on Varien_Objects to setData()/getData()
- flipped @var annotations
- ...
@sreichel sreichel changed the title Mage_Customer - IDE improvements Mage_Core - IDE improvements May 29, 2019
@sreichel sreichel added the hold label May 29, 2019
kkrieger85
kkrieger85 suggested changes Jun 1, 2019
View reviewed changes
Copy link
Contributor

@kkrieger85 kkrieger85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment concerning magic methods/setData/getData

@sreichel
Copy link
Contributor Author

sreichel commented Jun 1, 2019

For some reason it looked like "InLine" ... it works since getter/setter have same key, but it will be reverted.

Q: idea was to make phpstan/phpstorm work with Varian_Objects. You cannot use annotations or something else, so the idea was to replace magic methods .... I've already reverted this in another PR and tried something else ... 088d028 Maybe this is better?

@wstnbrg wstnbrg added the work in progress For Pull Requests which still have changes planned label Jun 1, 2019
@sreichel sreichel closed this Jun 2, 2019
@sreichel sreichel deleted the cleanup/Core branch June 2, 2019 12:37
@sreichel sreichel added invalid and removed work in progress For Pull Requests which still have changes planned hold labels Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrieger85 kkrieger85 kkrieger85 requested changes

Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sreichel @kkrieger85 @wstnbrg