Skip to content

Commit

Permalink
Refs #127. Generate DLL without a version suffix on Windows.
Browse files Browse the repository at this point in the history
  • Loading branch information
zchothia committed Jul 30, 2012
1 parent 3108a18 commit e8306f6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 0 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -99,11 +99,9 @@ ifeq ($(OSNAME), Darwin)
endif
ifeq ($(OSNAME), WINNT)
$(MAKE) -C exports dll
-ln -fs $(LIBDLLNAME) $(LIBPREFIX).dll
endif
ifeq ($(OSNAME), CYGWIN_NT)
$(MAKE) -C exports dll
-ln -fs $(LIBDLLNAME) $(LIBPREFIX).dll
endif

tests :
Expand Down
2 changes: 1 addition & 1 deletion Makefile.system
Original file line number Diff line number Diff line change
Expand Up @@ -724,8 +724,8 @@ endif
endif


LIBDLLNAME = $(LIBPREFIX).dll
LIBSONAME = $(LIBNAME:.$(LIBSUFFIX)=.so)
LIBDLLNAME = $(LIBNAME:.$(LIBSUFFIX)=.dll)
LIBDYNNAME = $(LIBNAME:.$(LIBSUFFIX)=.dylib)
LIBDEFNAME = $(LIBNAME:.$(LIBSUFFIX)=.def)
LIBEXPNAME = $(LIBNAME:.$(LIBSUFFIX)=.exp)
Expand Down
5 changes: 5 additions & 0 deletions exports/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ dll : ../$(LIBDLLNAME)

dll2 : libgoto2_shared.dll

# On Windows, we only generate a DLL without a version suffix. This is because
# applications which link against the dynamic library reference a fixed DLL name
# in their import table. By instead using a stable name it is possible to
# upgrade between library versions, without needing to re-link an application.
# For more details see: https://github.com/xianyi/OpenBLAS/issues/127.
../$(LIBDLLNAME) : ../$(LIBNAME) libopenblas.def dllinit.$(SUFFIX)
$(RANLIB) ../$(LIBNAME)
ifeq ($(BINARY32), 1)
Expand Down

0 comments on commit e8306f6

Please sign in to comment.