Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BLAS and LAPACK tests for C910V and RISCV64_ZVL256B targets #4454

Merged
merged 4 commits into from
Jan 26, 2024

Conversation

AndreySokolovSC
Copy link
Contributor

@AndreySokolovSC AndreySokolovSC commented Jan 24, 2024

  • Fixed bugs in dgemm(), [a]min()\max(), asum() kernels
  • Added zero checks for BLAS kernels
  • Added dsdot() implementation for RVV 0.7.1
  • Added additional definitions for RISCV64_ZVL256B target
  • Fix x280 compilation error

All BLAS tests passed.

С910 LAPACK tests (Fortran sources, Int32):

SUMMARY nb test run numerical error other error
================ =========== ================= ================
REAL 1318557 97 (0.007%) 0 (0.000%)
DOUBLE PRECISION 1327845 0 (0.000%) 0 (0.000%)
COMPLEX 786775 0 (0.000%) 0 (0.000%)
COMPLEX16 787842 0 (0.000%) 0 (0.000%)

--> ALL PRECISIONS 4221019 97 (0.002%) 0 (0.000%)

C LAPACK sources, Int32\64 is simular with fixes from #4453
97 fails for SHSEQR function and its related with C910 gemm kernel. We haven't been able to find the cause of the problem yet.

RISCV64_ZVL256B LAPACK tests (Fortran sources, Int32):
SUMMARY nb test run numerical error other error
================ =========== ================= ================
REAL 1327023 0 (0.000%) 0 (0.000%)
DOUBLE PRECISION 1327845 0 (0.000%) 0 (0.000%)
COMPLEX 786775 0 (0.000%) 0 (0.000%)
COMPLEX16 787842 0 (0.000%) 0 (0.000%)

--> ALL PRECISIONS 4229485 0 (0.000%) 0 (0.000%)

kseniyazaytseva and others added 4 commits January 23, 2024 19:01
* Fixed bugs in dgemm, [a]min\max, asum kernels
* Added zero checks for BLAS kernels
* Added dsdot implementation for RVV 0.7.1
* Fixed bugs in _vector files for C910V and RISCV64_ZVL256B targets
* Added additional definitions for RISCV64_ZVL256B target
@AndreySokolovSC AndreySokolovSC changed the title Riscv rvv07 Fix BLAS and LAPACK tests for C910V and RISCV64_ZVL256B targets Jan 24, 2024
@martin-frbg martin-frbg merged commit 4e2a32f into OpenMathLib:risc-v Jan 26, 2024
14 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants