Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Connectable observable for signalling client #18

Closed
vkkhare opened this issue Jan 29, 2020 · 2 comments · Fixed by #51
Closed

Use Connectable observable for signalling client #18

vkkhare opened this issue Jan 29, 2020 · 2 comments · Fixed by #51
Assignees
Labels
Type: New Feature ➕ Introduction of a completely new addition to the codebase

Comments

@vkkhare
Copy link
Member

vkkhare commented Jan 29, 2020

A better way is to allow the user to have access to observer and let him subscribe to it as per his use case. This will be a more reactive approach for the user of lib as well.

Additionally this will allow us to have parallel subscriptions to socket channel. But, we would need to decide when to dispose the connections as some subscribers would be just UI based subscribers who will have less priority in deciding whether the connection to pygrid should exist or not. So a simple rxjava:refcount wont work for us

@vkkhare vkkhare added the Type: New Feature ➕ Introduction of a completely new addition to the codebase label Jan 29, 2020
@vkkhare
Copy link
Member Author

vkkhare commented Jan 30, 2020

with #19 this would require its implementation to be done in syft.kt which will be handling the subscribers

@vkkhare
Copy link
Member Author

vkkhare commented Feb 26, 2020

#51 implements this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant