Fix setting partition selection field in utility analysis result #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvadym
changed the title
dvadym
requested review from
sushkoy and
monsieurmuffin
and removed request for
sushkoy
monsieurmuffin
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partition selection strategy (which is enum of TruncatedGeometric, LaplaceThresholding and GaussianThresholding) is a part of utility analysis parameters. So it should be part of the output as well. But before this PR it was set incorectly, namely
configuration_indexis used for finding what is partition selection for a fixed configuration of parameters. Butconfiguration_indexwas not yet available in that moment. This PR fixes that by moving settingpartition_selection_strategylater in the pipeline, whenconfiguration_indexis available