Sum per partition histogram #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamSaw
approved these changes
Dec 2, 2023
| "map to lowers") | ||
| def generate_lowers(min_max: Tuple[float, float]) -> List[float]: | ||
| min_, max_ = min_max | ||
| if min_ == max_: |
There was a problem hiding this comment.
will it generate min_ number_of_buckets + 1 times otherweise?
| @@ -185,7 +185,8 @@ def test_find_candidate_parameters_count(self, max_value, max_candidates, | |||
| mock_l0_histogram.max_value = mock.Mock(return_value=max_value) | |||
|
|
|||
| mock_histograms = histograms.DatasetHistograms(mock_l0_histogram, None, | |||
| None, None, None, None) | |||
| None, None, None, None, | |||
| None) | |||
There was a problem hiding this comment.
weird formatting but maybe that's what the tool generates
| sum=-10.0, | ||
| max=-1.0), | ||
| hist.FrequencyBin(lower=0.0, | ||
| upper=0.00019999999999997797, |
There was a problem hiding this comment.
hm, so this value we have here due to imprecise math, should then try to assert with an interval around 0.0002? But I guess then assertion will be more complicated because we won't be able to assert just like assert(actual == expected).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Computing histogram for sum per partition (i.e. of non-dp sum per partition). Its computation similar to
linf_sum_contributions_histogram: i.e. the range between min/max split on 10^4 bins and count/sum/max for each bin is computed.