Introduce boolean variable for enabling/disabling of cross partition contribution bounding #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monsieurmuffin
approved these changes
May 17, 2024
monsieurmuffin
approved these changes
May 17, 2024
tests/contribution_bounders_test.py
Outdated
| self.assertLen(bound_result[('pid1', 'pk1')], 1) | ||
| self.assertLen(bound_result[('pid2', 'pk1')], 1) | ||
|
|
||
| def test_sampling_applied_nothing_dropped(self): |
There was a problem hiding this comment.
nit: I would rename this methods to "test_more_contributions_than_bound_nothing_dropped" to make it clear that we expect all contributions to be kept under specific circumstances.
tests/dp_engine_test.py
Outdated
| unittest.mock.ANY) | ||
|
|
||
| @patch('pipeline_dp.contribution_bounders.NoOpSampler.bound_contributions') | ||
| def test_aggregate_computation_graph_only_no_sampling_for_sum_when_no_cross_partition( |
There was a problem hiding this comment.
in "test_aggregate_computation_graph_only_no_sampling_for_sum_when_no_cross_partition"
what does "only" refer to? is it "only test graph and nothing else"? In that case, I think we can drop "only". "test_computational_graph" already indicates what's being tested.
There was a problem hiding this comment.
thx, we can drop only. Done
dvadym
commented
May 17, 2024
tests/contribution_bounders_test.py
Outdated
| self.assertLen(bound_result[('pid1', 'pk1')], 1) | ||
| self.assertLen(bound_result[('pid2', 'pk1')], 1) | ||
|
|
||
| def test_sampling_applied_nothing_dropped(self): |
tests/dp_engine_test.py
Outdated
| unittest.mock.ANY) | ||
|
|
||
| @patch('pipeline_dp.contribution_bounders.NoOpSampler.bound_contributions') | ||
| def test_aggregate_computation_graph_only_no_sampling_for_sum_when_no_cross_partition( |
There was a problem hiding this comment.
thx, we can drop only. Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.