Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of Pipenv #292

Closed
2 tasks
alejandrosame opened this issue Sep 13, 2020 · 9 comments
Closed
2 tasks

Get rid of Pipenv #292

alejandrosame opened this issue Sep 13, 2020 · 9 comments
Assignees
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Status: Available 👋 Available for assignment, who wants it? Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase

Comments

@alejandrosame
Copy link
Member

What?

For our use case, Pipenv introduces several problems for little gain. We should check how to substitute it.

Why?

Substituting pipenv means that we need to change code in several setup/admin files. The options considered are:

  • Check moving to Poetry -> Moving from Pipenv to Poetry #277
  • If Poetry proves to be also problematic, fallback to pip+venv and provide Make targets to make them easy to use and standard.

Additional Context

This issue is best to be worked on after #289 is solved.

@alejandrosame alejandrosame added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase labels Sep 13, 2020
@alejandrosame alejandrosame added this to the Repository improvements milestone Sep 13, 2020
@chinmayshah99 chinmayshah99 added the Status: Available 👋 Available for assignment, who wants it? label Sep 14, 2020
@BrendanSchell
Copy link
Contributor

@alejandrosame can I take this on?

@alejandrosame
Copy link
Member Author

alejandrosame commented Oct 4, 2020

@BrendanSchell You are more than welcome to take this task :) If you agree, as it is suggested in the description, we can assign you #277 and you can focus on updating the Makefile to substitute pipenv with poetry to begin with.

I hope to not take too long with #289 so these changes can be tested more seamlessly, but is not a hard requirement, it's mostly for convenience. Otherwise, once you make the Makefile targets work with poetry, further updates will be needed on different files around the repository.

@BrendanSchell
Copy link
Contributor

@alejandrosame That sounds good to me - I can take on #277 for now to update the Makefile to try out poetry.

@alejandrosame
Copy link
Member Author

Hi @BrendanSchell, how is the task going?

If you have any doubt, do not hesitate to contact us also through Slack, we are quite active there.

@BrendanSchell
Copy link
Contributor

@alejandrosame thanks for checking in! Made the change to the makefile and should have some time to test out later today.

@mhosankalp
Copy link
Contributor

Hi,

Can I take this one or it is already been worked upon?

Thanks and Regards,
Sankalp

@alejandrosame
Copy link
Member Author

alejandrosame commented Oct 21, 2020

Hi @mhosankalp, BrendanSchell is already working on this task!

If you don't find a task to work on, you can always contact us on Slack to see how can we guide you.

@mhosankalp
Copy link
Contributor

Thanks @alejandrosame. I will take another one

@chinmayshah99
Copy link
Member

#310 solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Status: Available 👋 Available for assignment, who wants it? Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Projects
None yet
Development

No branches or pull requests

4 participants