This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IonesioJunior
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @victorperezc!
This was referenced Apr 21, 2021
AmrMKayid
added a commit
that referenced
this pull request
Apr 23, 2021
* dev: Minor improvements Update dataset creation return to follow get/get_all pattern Update README.md Update /setup unit tests Minor fixes minor fixes Datasets refactory (#839) Fix/813 (#829) Update pre-commit to include checks of documentation (#834) Remove outdated notebook examples Update readme example (#837)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing Bugs in Issue #813 #803 .
The global middleware is like a barrier between the actual endpoints logic and the wgsi application. It executes some logic in the middle and decides whether continue with the user request or throw an error. In this case, checks whether there exists an Initial Setup configured to continue with the user request. Otherwise, if the request is done on another resource other than
POST /setup
he is not allowed to access and the app raises401
Not Allowed. This way the app is like 'sleeping' until it's configured throughPOST /setup
and all other api calls are blockedFlow and expected behaviour
POST /setup
. You should get401
and the following message"error": "This app is in sleep mode. Please undergo the initial setup first"
POST /setup
to configure the domain and create the owner account. Once you get a200
, the domain has been successfully configured. For your request to go through you'd need to add the setup verification token9G9MJ06OQH
via POST parameters. For now, this is hardcoded in the environment for development purposes.How has this been tested?
Locally tested
Checklist