Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated tutorials into French Part 1 (OpenMind #2782 and #2779) #2881

Closed
wants to merge 25 commits into from
Closed

Translated tutorials into French Part 1 (OpenMind #2782 and #2779) #2881

wants to merge 25 commits into from

Conversation

Metrix1010
Copy link

examples/tutorials/translations/french/Part 01 - The Basic Tools of Private Deep Learning.ipynb

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

LaRiffle
LaRiffle suggested changes Jan 3, 2020
View reviewed changes
Copy link
Contributor

@LaRiffle LaRiffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
Thanks for this PR!
Did you use a software to translate to French?
I have the feeling that some of the expressions sound a bit awkward.
If you did so, then you might want to spend some time proof reading the translation.

TTitcombe
TTitcombe reviewed Jan 3, 2020
View reviewed changes
examples/tutorials/translations/french/Part 01 - The Basic Tools of Private Deep Learning.ipynb Outdated Show resolved Hide resolved
examples/tutorials/translations/french/Part 01 - The Basic Tools of Private Deep Learning.ipynb Outdated Show resolved Hide resolved
examples/tutorials/translations/french/Part 01 - The Basic Tools of Private Deep Learning.ipynb Outdated Show resolved Hide resolved
examples/tutorials/translations/french/Part 01 - The Basic Tools of Private Deep Learning.ipynb
"hotkey": "alt-t",
"langInMainMenu": true,
"sourceLang": "en",
"targetLang": "fr",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably don't want this translation metadata in the notebooks

examples/tutorials/translations/french/Part 01 - The Basic Tools of Private Deep Learning.ipynb Outdated
"\n",
"- [Star PySyft] (https://github.com/OpenMined/PySyft)\n",
"\n",
"### Rejoignez notre Slack!\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would se joindre be the correct verb here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes @TTitcombe you're right!

@ThomAub
Copy link

ThomAub commented Jan 15, 2020

I would love to help on this PR and translate the remaining notebooks. I am currently diving back to the project and it can be a good way to catch up.
Is It ok if I add comments on this one and create another PR for the other ones ?

Metrix1010 and others added 3 commits January 20, 2020 15:31
@Metrix1010 @TTitcombe
Update examples/tutorials/translations/french/Part 01 - The Basic Too…
5664381 
…ls of Private Deep Learning.ipynb

Co-Authored-By: Tom <32938439+TTitcombe@users.noreply.github.com>
@Metrix1010 @TTitcombe
Apply suggestions from code review
59b6822 
Thank you for catching those.

Co-Authored-By: Tom <32938439+TTitcombe@users.noreply.github.com>
@Metrix1010
Merge branch 'master' into master
93fd3cf
@LaRiffle
Copy link
Contributor

I don't think you can push here maybe you'll want ot open a dedicated PR :)

This was referenced Feb 26, 2020
Merged
Closed
@karlhigley karlhigley requested a review from a team March 22, 2020 13:42
srishilesh
srishilesh reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@srishilesh srishilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LaRiffle One test under test coverage has been cancelled. Is it okay to merge without the test passing?

@r0cketr1kky r0cketr1kky mentioned this pull request Apr 7, 2020
Closed
@Metrix1010 Metrix1010 requested a review from a team as a code owner April 12, 2020 18:45
@srishilesh srishilesh requested review from srishilesh and removed request for a team April 13, 2020 03:50
srishilesh
srishilesh approved these changes Apr 13, 2020
View reviewed changes
Copy link
Member

@srishilesh srishilesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and merging French translations for part 1
Issue resolved #2881

@srishilesh
Copy link
Member

@Metrix1010 Fix those requested changes. Once fixed, I will be able to merge them.

@Metrix1010
Copy link
Author

@Metrix1010 Fix those requested changes. Once fixed, I will be able to merge them.

Please let me know if this is correct. I used git rebase to update my local fork but I did not use the force command. I used merge, pull and push.

@github-actions
Copy link

github-actions bot commented Jun 1, 2020

This pull request has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.

@github-actions github-actions bot added the Status: Stale 🍞 Been open for a while with no activity label Jun 1, 2020
@github-actions github-actions bot closed this Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTitcombe TTitcombe TTitcombe left review comments

@r0cketr1kky r0cketr1kky r0cketr1kky left review comments

@LaRiffle LaRiffle LaRiffle requested changes

@srishilesh srishilesh srishilesh approved these changes

Assignees
No one assigned
Labels
Status: Stale 🍞 Been open for a while with no activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Metrix1010 @ThomAub @LaRiffle @srishilesh @TTitcombe @r0cketr1kky @karlhigley