Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ObjectRequestMessage for async example #2948

Merged
merged 1 commit into from Jan 22, 2020
Merged

ObjectRequestMessage for async example #2948

merged 1 commit into from Jan 22, 2020

Conversation

brandonhee
Copy link
Contributor

The MNIST async websocket exampe fails because the workers cannot unpack an int. The message sent needs to be the tuple defined previously.

LaRiffle
LaRiffle approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@LaRiffle LaRiffle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thanks!

(correct usage indeed can be found in base.py line 623 obj = self.send_msg(ObjectRequestMessage((obj_id, user, reason)), location))

@LaRiffle LaRiffle merged commit ea65393 into OpenMined:master Jan 22, 2020
@brandonhee brandonhee mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LaRiffle LaRiffle LaRiffle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandonhee @LaRiffle