Extract a Role class from Plans #3201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
added
plans
Type: Refactor 🔨
Jasopaum
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3201 +/- ##
==========================================
+ Coverage 94.60% 94.67% +0.06%
==========================================
Files 149 148 -1
Lines 15917 16023 +106
==========================================
+ Hits 15058 15169 +111
+ Misses 859 854 -5
|
Jasopaum
changed the title
iamtrask
requested changes
Mar 31, 2020
syft/execution/role.py
Outdated
| # TODO isn't it weird that state placeholders are both in state and plan? | ||
| self.placeholders[tensor.id] = placeholder | ||
|
|
||
| def fecth_placeholders_from_ids(self, obj): |
There was a problem hiding this comment.
typo fetch_placeholders_from_ids
There was a problem hiding this comment.
Thanks! Just fixed that
karlhigley
approved these changes
Mar 31, 2020
| @@ -17,7 +17,7 @@ def __init__( | |||
| self, | |||
| id: int = None, | |||
| owner: "sy.workers.AbstractWorker" = None, | |||
| tags: List[str] = None, | |||
| tags: Set[str] = None, | |||
| # out += line | ||
|
|
||
| # out += " return " | ||
| # out += ", ".join(f"_{extract_tag(p)}" for p in self.find_placeholders("output")) |
There was a problem hiding this comment.
Can we remove this now? 👍
There was a problem hiding this comment.
I want to because I don't find it very useful to print a list of actions like that... What do you think?
iamtrask
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.