Add a protocol kwarg to encrypt() method to select between MPC and Paillier HE
#3234
Conversation
Checkout to earlier commit for version with both
Codecov Report
@@ Coverage Diff @@
## master #3234 +/- ##
=========================================
Coverage ? 94.54%
=========================================
Files ? 146
Lines ? 15920
Branches ? 0
=========================================
Hits ? 15052
Misses ? 868
Partials ? 0
|
|
Please always use other than your master branch for creating PR |
test/torch/tensors/test_native.py
Outdated
|
|
||
| x = torch.randint(10, (1, 5), dtype=torch.float32) | ||
| x_encrypted = x.encrypt(workers=[bob, alice], crypto_provider=james, args_fix_prec={"base": 10}) | ||
| assert torch.all(torch.eq(x_encrypted.get().float_prec(), x)) |
There was a problem hiding this comment.
Oh we've forgotten to add a generic decrypt method!!
Would you be willing to do also this one? :)
for MPC .decrypt() would call .get().float_prec()
and for paillier, it would'nt change
There was a problem hiding this comment.
Sure. Do I submit it in another PR?
I've incorporated the suggestions mentioned.
There was a problem hiding this comment.
In this PR would be more coherent if you can do it !
Thanks to @Jasopaum
karlhigley
changed the title
protocol kwarg to encrypt() method to select between MPC and Paillier HE
| """ | ||
|
|
||
| if protocol.lower() == "mpc": | ||
| x_encrypted = self.copy() |
There was a problem hiding this comment.
@LaRiffle It served a purpose of not making it an inplace operation
There was a problem hiding this comment.
Oh I see
Ok I got your point, let's keep it your way
Fixes #3212