Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pull request template #3268

Merged
merged 2 commits into from
Apr 17, 2020
Merged

Added pull request template #3268

merged 2 commits into from
Apr 17, 2020

Conversation

sachin-101
Copy link
Contributor

  • Pull request templates are a nice feature that helps the contributor to add relevant information about their pull request.
  • They also help the reviewer to verify that the necessary guidelines of contributing have been followed.
  • Thus helping in maintaining the repo. :)

@codecov
Copy link

codecov bot commented Mar 28, 2020 •
edited

Codecov Report

Merging #3268 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3268   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files         149      149           
  Lines       15917    15917           
=======================================
  Hits        15058    15058           
  Misses        859      859

@sachin-101
Copy link
Contributor Author

@karlhigley Please review this PR.

@sachin-101
Copy link
Contributor Author

@karlhigley Please review this PR.

karlhigley
karlhigley suggested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@karlhigley karlhigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but maybe heavier weight than we need for now. Suggested a few changes to slim it down a bit.

.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
.github/pull_request_template.md Outdated Show resolved Hide resolved
@karlhigley karlhigley added the Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase label Apr 4, 2020
@karlhigley karlhigley merged commit 13224d8 into OpenMined:master Apr 17, 2020
@sachin-101 sachin-101 deleted the add_pr_template branch April 17, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TTitcombe TTitcombe TTitcombe left review comments

@karlhigley karlhigley karlhigley approved these changes

Assignees
No one assigned
Labels
Type: Documentation 📚 Improvements or additions in documentation for some file, feature, or codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sachin-101 @karlhigley @TTitcombe