Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework PlanTranslatorTorchscript so it doesn't strip Parameters #3376

Merged
merged 1 commit into from
Apr 19, 2020

Conversation

Syzygianinfern0
Copy link
Member

Resolve Conficts, merge with master

It turns out jit.trace() strips Parameters out of the tensor chain,
which causes issues with fix_precision. Don't fully understand why
jit.trace() does that, but operating on a copy of the original Plan
avoid mutating the original State tensors, which fixes the issue.
@karlhigley #3375

@Syzygianinfern0 Syzygianinfern0 requested a review from a team as a code owner April 19, 2020 18:20
@codecov
Copy link

codecov bot commented Apr 19, 2020

Codecov Report

Merging #3376 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3376      +/-   ##
==========================================
- Coverage   94.71%   94.68%   -0.02%     
==========================================
  Files         151      151              
  Lines       16294    16291       -3     
==========================================
- Hits        15431    15424       -7     
- Misses        863      867       +4     
Impacted Files Coverage Δ
syft/execution/translation/torchscript.py 100.00% <100.00%> (ø)
syft/generic/pointers/object_pointer.py 78.20% <0.00%> (-3.75%) ⬇️
syft/execution/state.py 90.27% <0.00%> (+0.89%) ⬆️

@karlhigley
Copy link
Contributor

test_fit is known to be flaky. 😢

@karlhigley karlhigley merged commit c414333 into OpenMined:master Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants