Garbage Collection in execute_computation_action, Fix Inplace-Operation Identification
#3403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Known to break inplace operations - Need to be made robust
Syzygianinfern0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3403 +/- ##
==========================================
- Coverage 94.72% 94.72% -0.01%
==========================================
Files 152 152
Lines 16137 16145 +8
==========================================
+ Hits 15286 15293 +7
- Misses 851 852 +1
|
Syzygianinfern0
changed the title
execute_computation_action, Fix Inplace-Operation Identification
Syzygianinfern0
changed the title
execute_computation_action, Fix Inplace-Operation Identificationexecute_computation_action, Fix Inplace-Operation Identification
7 tasks
Syzygianinfern0
added
Type: Bug 🐛
|
@LaRiffle would you please review this quickly :) |
karlhigley
suggested changes
Apr 27, 2020
Fix regex bug Add regex tests Cleanup unused codes and TODOs
LaRiffle
approved these changes
Apr 28, 2020
karlhigley
approved these changes
Apr 28, 2020
| # hence creating two copies of the same info. The older tensor | ||
| # is left hanging and is never deleted. De-Registering the original | ||
| # tensor (if-exists) before registration addresses this problem. | ||
| owner.de_register_obj(tensor) # Doesn't raise Exceptions if absent on owner |
tudorcebere
pushed a commit
to tudorcebere/PySyft
that referenced
this pull request
May 7, 2020
…tion Identification (OpenMined#3403) * Garbage identified * Garbage Cleared Known to break inplace operations - Need to be made robust * Checkpoint * Regex magic for inplace operations * Complete move to regex * Cleanup * Multiple changes Fix regex bug Add regex tests Cleanup unused codes and TODOs * Typo
tudorcebere
pushed a commit
to tudorcebere/PySyft
that referenced
this pull request
May 7, 2020
…tion Identification (OpenMined#3403) * Garbage identified * Garbage Cleared Known to break inplace operations - Need to be made robust * Checkpoint * Regex magic for inplace operations * Complete move to regex * Cleanup * Multiple changes Fix regex bug Add regex tests Cleanup unused codes and TODOs * Typo
tudorcebere
pushed a commit
to tudorcebere/PySyft
that referenced
this pull request
May 7, 2020
…tion Identification (OpenMined#3403) * Garbage identified * Garbage Cleared Known to break inplace operations - Need to be made robust * Checkpoint * Regex magic for inplace operations * Complete move to regex * Cleanup * Multiple changes Fix regex bug Add regex tests Cleanup unused codes and TODOs * Typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3397
Fixes #3398
Currently breaks inplace computations. WIP 🚧🚧Type of change
Please mark options that are relevant.
Checklist: