Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused method .value() #3418

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

Jasopaum
Copy link
Member

Description

Thank you for your contribution to the PySyft repository.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

If your pull request closes a GitHub issue, then set its number below.

Fixes # (issue)

Type of change

Please mark options that are relevant.

  • Added/Modified tutorials
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@Jasopaum Jasopaum requested a review from a team as a code owner April 28, 2020 19:27
@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #3418 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #3418    +/-   ##
========================================
  Coverage   94.71%   94.72%            
========================================
  Files         152      152            
  Lines       16148    16044   -104     
========================================
- Hits        15295    15197    -98     
+ Misses        853      847     -6     
Impacted Files Coverage Δ
syft/execution/communication.py 96.07% <ø> (ø)
...ft/frameworks/torch/tensors/interpreters/native.py 91.07% <ø> (+0.18%) ⬆️
syft/generic/pointers/pointer_tensor.py 92.73% <ø> (+1.48%) ⬆️
syft/execution/state.py 88.54% <0.00%> (-1.09%) ⬇️
syft/workers/base.py 92.62% <0.00%> (-0.02%) ⬇️
test/execution/test_plan.py 100.00% <0.00%> (ø)
test/execution/test_state.py 100.00% <0.00%> (ø)
syft/execution/plan.py 93.65% <0.00%> (+0.05%) ⬆️
syft/execution/tracing.py 94.44% <0.00%> (+0.15%) ⬆️
syft/execution/role.py 99.46% <0.00%> (+0.98%) ⬆️

Copy link
Contributor

@Prtfw Prtfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@Jasopaum Jasopaum merged commit acafc7e into OpenMined:master Apr 28, 2020
tudorcebere pushed a commit to tudorcebere/PySyft that referenced this pull request May 7, 2020
tudorcebere pushed a commit to tudorcebere/PySyft that referenced this pull request May 7, 2020
tudorcebere pushed a commit to tudorcebere/PySyft that referenced this pull request May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants