Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for notebooks in Autoscale #3483

Merged
merged 17 commits into from May 16, 2020
Merged

Added support for notebooks in Autoscale #3483

merged 17 commits into from May 16, 2020

Conversation

rimijoker
Copy link
Member

Description

Added support for autoscale on notebooks, previously it could only be run using a python script.
Now it can be run using both script (.py) and notebook(.ipynb).

@hericlesme
#3099(issue)

Type of change

Please mark the options that are relevant.

  • Added/Modified tutorials
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

Review Jupyter notebook visual diffs & provide feedback on notebooks.


Powered by ReviewNB

@karlhigley karlhigley added the grid label May 9, 2020
@karlhigley karlhigley added this to Grid Team in Cross-team Requests May 9, 2020
@monuelo monuelo self-requested a review May 9, 2020 17:21
@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #3483 into master will decrease coverage by 0.00%.
The diff coverage is 98.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3483      +/-   ##
==========================================
- Coverage   94.78%   94.78%   -0.01%     
==========================================
  Files         159      159              
  Lines       17174    17247      +73     
==========================================
+ Hits        16279    16348      +69     
- Misses        895      899       +4     
Impacted Files Coverage Δ
syft/execution/action.py 91.30% <ø> (ø)
syft/messaging/message.py 93.85% <ø> (ø)
syft/workers/websocket_client.py 58.21% <0.00%> (ø)
test/serde/serde_helpers.py 100.00% <ø> (ø)
syft/workers/base.py 90.76% <89.47%> (+0.17%) ⬆️
syft/exceptions.py 77.91% <100.00%> (ø)
syft/federated/federated_client.py 95.49% <100.00%> (ø)
...orks/torch/tensors/interpreters/additive_shared.py 94.25% <100.00%> (ø)
syft/generic/object.py 93.42% <100.00%> (ø)
syft/generic/object_storage.py 97.22% <100.00%> (ø)
... and 41 more

syft/grid/autoscale/test.ipynb Outdated Show resolved Hide resolved
@rimijoker rimijoker requested a review from monuelo May 16, 2020 05:19
Copy link
Member

@monuelo monuelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 🚀

@monuelo monuelo merged commit 6b55ba0 into OpenMined:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants