Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace generation actions like torch.rand() into Roles in Protocols #3522

Merged

Conversation

karlhigley
Copy link
Contributor

@karlhigley karlhigley commented May 13, 2020

Description

Makes it possible to trace tensor generation methods called on framework modules (like torch) into Protocol Roles.

Resolves #3492

NOTE TO REVIEWERS: This PR is based on #3521, and only the last commit is new.

Checklist:

  • My changes are covered by tests.
  • I have run the pre-commit hooks to format and check my code for style issues.
  • I have commented my code following Google style.

(See the the contribution guidelines for additional tips.)

@karlhigley karlhigley requested a review from a team as a code owner May 13, 2020 16:54
@karlhigley karlhigley requested review from LaRiffle and Prtfw May 13, 2020 16:54
@karlhigley karlhigley added protocols Type: New Feature ➕ Introduction of a completely new addition to the codebase labels May 13, 2020
@karlhigley karlhigley self-assigned this May 13, 2020
@karlhigley karlhigley force-pushed the feature/protocol-tensor-generation branch from 9c63e96 to 70fd263 Compare May 13, 2020 17:01
@karlhigley karlhigley force-pushed the feature/protocol-tensor-generation branch from 70fd263 to 855299d Compare May 13, 2020 17:07
Copy link
Member

@Jasopaum Jasopaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

syft/workers/base.py Outdated Show resolved Hide resolved
syft/execution/role.py Outdated Show resolved Hide resolved
@karlhigley karlhigley requested a review from Jasopaum May 13, 2020 22:09
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #3522 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3522      +/-   ##
==========================================
- Coverage   94.78%   94.78%   -0.01%     
==========================================
  Files         159      159              
  Lines       17176    17189      +13     
==========================================
+ Hits        16281    16292      +11     
- Misses        895      897       +2     
Impacted Files Coverage Δ
syft/execution/role.py 98.10% <100.00%> (+0.03%) ⬆️
test/execution/test_protocol.py 100.00% <100.00%> (ø)
syft/execution/plan.py 94.73% <0.00%> (-0.66%) ⬇️

@karlhigley karlhigley merged commit 1b41469 into OpenMined:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible for Protocols to generate tensors on specific Roles/Workers
2 participants