FL MNIST example with autograd tracing #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #3567 +/- ##
==========================================
- Coverage 94.76% 94.65% -0.12%
==========================================
Files 159 160 +1
Lines 17269 17294 +25
==========================================
+ Hits 16365 16369 +4
- Misses 904 925 +21
|
iamtrask
reviewed
May 21, 2020
| @@ -181,3 +181,103 @@ def autograd_test(X): | |||
|
|
|||
| # Test all results are equal | |||
| assert torch_grads.eq(ts_plan_grads).all() | |||
|
|
|||
|
|
|||
| def test_fl_mnist_example_training_can_be_translated(hook, workers): | |||
iamtrask
approved these changes
May 21, 2020
karlhigley
reviewed
May 21, 2020
| @@ -100,7 +120,7 @@ def __init__(self, self_, other): | |||
| self.other = other | |||
|
|
|||
| def gradient(self, grad): | |||
| assert isinstance(self.other, int) | |||
| # assert isinstance(self.other, int) | |||
There was a problem hiding this comment.
No longer needed or worth keeping?
There was a problem hiding this comment.
This div code was made for ints, but it seems to works fine for tensor (with scalar value at least).
@LaRiffle do you see any problem with removing this assert?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to use autograd tracing (in its existing form) to trace MNIST example for static FL.
Initially, there's unit test that should pass.
Next, notebooks should be updated.
Checklist:
(See the the contribution guidelines for additional tips.)