Remove protocol parameter in decrypt #3599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3599 +/- ##
==========================================
+ Coverage 94.58% 94.62% +0.04%
==========================================
Files 160 160
Lines 17179 17192 +13
==========================================
+ Hits 16248 16268 +20
+ Misses 931 924 -7
|
LaRiffle
suggested changes
May 25, 2020
| protocol = kwargs.get("protocol", None) | ||
| if protocol: | ||
| warnings.warn("protocol should no longer be used in decrypt") | ||
|
|
There was a problem hiding this comment.
Beware of the case where we have an AutogradTensor
There was a problem hiding this comment.
I thought that passing tests meant it's working fine, but yeah there was no tests for decrypting an AutogradTensor. Fixed that and added test for decrypting with/without grad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR remove the need to a
protocolparameter indecryptand warn the user to not use it, without raising an error.Resolves #3329
Checklist:
(See the the contribution guidelines for additional tips.)