Register the translation mark with PyTest to suppress warnings
#3618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mark is used in the test suite to designate tests that should only run during the translation tests and not as part of the regular notebook tests. It works fine now, but results in warnings from PyTest at the end of the test suite output about an unregistered mark. This change makes the warnings go away, but otherwise doesn't change anything about the functionality of the test suite.
karlhigley
added
the
Type: Improvement 📈
karlhigley
requested review from
a team,
shubham3121 and
imskr
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #3618 +/- ##
==========================================
+ Coverage 94.64% 94.66% +0.01%
==========================================
Files 160 160
Lines 17192 17194 +2
==========================================
+ Hits 16272 16277 +5
+ Misses 920 917 -3
|
shubham3121
approved these changes
May 28, 2020
There was a problem hiding this comment.
Looks good to me. 👍
@karlhigley
FYR: Notebook tests are failing because of examples/tutorials/advanced/Federated Dataset.ipynb fetches datasets from two urls which are now throwing 403.
|
@shubham3121 Thanks, didn't catch that! Looks like it might have been a temporary issue, but if it persists, we can open an issue. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This mark is used in the test suite to designate tests that should only
run during the translation tests and not as part of the regular notebook
tests. It works fine now, but results in warnings from PyTest at the end
of the test suite output about an unregistered mark. This change makes
the warnings go away, but otherwise doesn't change anything about the
functionality of the test suite.
Type of Change
Please mark options that are relevant.
Checklist