-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto messaging support #3638
Merged
tudorcebere
merged 9 commits into
OpenMined:master
from
tudorcebere:proto_messaging_support
Jun 1, 2020
Merged
Proto messaging support #3638
tudorcebere
merged 9 commits into
OpenMined:master
from
tudorcebere:proto_messaging_support
Jun 1, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
tudorcebere
added
serialization
Type: Improvement 📈
Minor improvements not introducing a new feature or requiring a major refactor
labels
May 30, 2020
Codecov Report
@@ Coverage Diff @@
## master #3638 +/- ##
==========================================
- Coverage 94.76% 94.74% -0.02%
==========================================
Files 182 182
Lines 17949 18032 +83
==========================================
+ Hits 17009 17085 +76
- Misses 940 947 +7
|
karlhigley
approved these changes
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Improvement 📈
Minor improvements not introducing a new feature or requiring a major refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Adding protobuf support for messaging, currenly,
WorkerCommandMessage
is not supported due to the fact that the test format only works for msgpack, not for protobuf as well. Will open an issue to rewrite that test.Affected Dependencies
List any dependencies that are required for this change.
Type of Change
Please mark options that are relevant.
How has this been tested?
Checklist
Additional Context
Please also include relevant motivation and context.