Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proto messaging support #3638

Merged
merged 9 commits into from
Jun 1, 2020

Conversation

tudorcebere
Copy link
Collaborator

@tudorcebere tudorcebere commented May 30, 2020

Pull Request

Description

Adding protobuf support for messaging, currenly, WorkerCommandMessage is not supported due to the fact that the test format only works for msgpack, not for protobuf as well. Will open an issue to rewrite that test.

Affected Dependencies

List any dependencies that are required for this change.

Type of Change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change which adds documentation)
  • Improvement (non-breaking change that improves the performance or reliability of existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Additional Context

Please also include relevant motivation and context.

@tudorcebere tudorcebere added serialization Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor labels May 30, 2020
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #3638 into master will decrease coverage by 0.01%.
The diff coverage is 91.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3638      +/-   ##
==========================================
- Coverage   94.76%   94.74%   -0.02%     
==========================================
  Files         182      182              
  Lines       17949    18032      +83     
==========================================
+ Hits        17009    17085      +76     
- Misses        940      947       +7     
Impacted Files Coverage Δ
syft/messaging/message.py 92.88% <91.25%> (-0.87%) ⬇️
test/serde/protobuf/test_protobuf_serde_full.py 100.00% <100.00%> (ø)

@tudorcebere tudorcebere merged commit f63bd71 into OpenMined:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants