Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] serde: added a registry class to track classes that needs to be seria… #3645

Closed
wants to merge 1 commit into from

Conversation

shubham3121
Copy link
Member

@shubham3121 shubham3121 commented May 30, 2020

Pull Request

Description

Added a registry class to track classes that needs to be serialised.
issue: #3626

Affected Dependencies

List any dependencies that are required for this change.

Type of Change

Please mark options that are relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation (non-breaking change which adds documentation)
  • Improvement (non-breaking change that improves the performance or reliability of existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

  • Describe the tests that you ran to verify your changes.
  • Provide instructions so we can reproduce.
  • List any relevant details for your test configuration.

Checklist

Additional Context

Please also include relevant motivation and context.

@shubham3121 shubham3121 added Type: New Feature ➕ Introduction of a completely new addition to the codebase Status: In Progress 🌟 This is actively being worked on labels May 30, 2020
@shubham3121 shubham3121 requested a review from a team as a code owner May 30, 2020 20:31
@shubham3121 shubham3121 self-assigned this May 30, 2020
@karlhigley
Copy link
Contributor

This overlaps a little bit with some of the existing work on SyftSerializable. Might want to confer with @tudorcebere on this one.

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #3645 into master will decrease coverage by 0.02%.
The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3645      +/-   ##
==========================================
- Coverage   94.76%   94.74%   -0.03%     
==========================================
  Files         182      182              
  Lines       17949    17967      +18     
==========================================
+ Hits        17009    17022      +13     
- Misses        940      945       +5     
Impacted Files Coverage Δ
syft/serde/syft_serializable.py 82.81% <72.22%> (-4.15%) ⬇️

@tudorcebere
Copy link
Collaborator

@shubham3121 We might be able to achieve this with existing work, could you describe what is the end goal of this class? (Where/why is it needed?)

@shubham3121
Copy link
Member Author

@tudorcebere this class can be used by libraries like Syfer text to register classes that needs to be serailized. Refer to this issue #3626

@shubham3121
Copy link
Member Author

shubham3121 commented Jun 2, 2020

@karlhigley Closing this PR as @tudorcebere is already working on the improvement.

@shubham3121 shubham3121 closed this Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress 🌟 This is actively being worked on Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants