Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Copy issue with ciphertext in FV scheme. #3672

Merged
merged 3 commits into from
Jun 6, 2020

Conversation

rav1kantsingh
Copy link
Member

Description

Closes #3671

How has this been tested?

Added tests for checking encryption-decryption of the same ciphertext without changing parameters (3 times)

Checklist

@rav1kantsingh rav1kantsingh added Crypto Team Priority: 1 - Immediate 🔥 Must be fixed immediately and cannot wait labels Jun 5, 2020
@rav1kantsingh rav1kantsingh modified the milestone: BFV Tensor in Python Jun 5, 2020
@codecov
Copy link

codecov bot commented Jun 5, 2020

Codecov Report

Merging #3672 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3672      +/-   ##
==========================================
+ Coverage   94.76%   94.77%   +0.01%     
==========================================
  Files         182      184       +2     
  Lines       17949    18227     +278     
==========================================
+ Hits        17009    17275     +266     
- Misses        940      952      +12     
Impacted Files Coverage Δ
syft/frameworks/torch/he/fv/decryptor.py 100.00% <100.00%> (ø)
test/torch/tensors/test_fv.py 100.00% <100.00%> (ø)
syft/generic/abstract/sendable.py 80.00% <0.00%> (-13.75%) ⬇️
syft/serde/syft_serializable.py 85.41% <0.00%> (-1.54%) ⬇️
syft/execution/plan.py 93.76% <0.00%> (-0.94%) ⬇️
syft/messaging/message.py 92.88% <0.00%> (-0.87%) ⬇️
syft/execution/tracing.py 93.10% <0.00%> (-0.23%) ⬇️
...ft/frameworks/torch/tensors/interpreters/native.py 91.28% <0.00%> (-0.02%) ⬇️
test/serde/serde_helpers.py 100.00% <0.00%> (ø)
test/generic/test_hookable.py 100.00% <0.00%> (ø)
... and 34 more

Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youben11 youben11 merged commit 27c6799 into OpenMined:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 1 - Immediate 🔥 Must be fixed immediately and cannot wait
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FV cipher-text data change during decryption.
2 participants