Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable timeout in workers #3760

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Customizable timeout in workers #3760

merged 2 commits into from
Jun 25, 2020

Conversation

youben11
Copy link
Member

@youben11 youben11 commented Jun 21, 2020

Description

Related to #3714 , we needed a mechanism to use a larger timeout when we know how much the computation will take. This PR gives the ability for experienced users to use a different timeout rather than the default which is 60 seconds.

Checklist

@youben11 youben11 added Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint labels Jun 21, 2020
@youben11 youben11 requested review from a team, karlhigley and Prtfw and removed request for a team June 21, 2020 06:28
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #3760 into master will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3760      +/-   ##
==========================================
+ Coverage   94.72%   94.74%   +0.01%     
==========================================
  Files         186      186              
  Lines       18459    18460       +1     
==========================================
+ Hits        17486    17490       +4     
+ Misses        973      970       -3     
Impacted Files Coverage Δ
syft/workers/node_client.py 30.00% <ø> (ø)
syft/workers/websocket_client.py 54.42% <66.66%> (+0.31%) ⬆️
syft/execution/plan.py 94.06% <0.00%> (-0.60%) ⬇️
syft/generic/pointers/object_pointer.py 82.22% <0.00%> (+3.70%) ⬆️

@youben11 youben11 requested a review from a team as a code owner June 21, 2020 07:45
@gmuraru
Copy link
Member

gmuraru commented Jun 22, 2020

LGTM!

@gmuraru gmuraru merged commit 8f5a95b into master Jun 25, 2020
@delete-merged-branch delete-merged-branch bot deleted the youben11/timeout branch June 25, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants