-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve public mul and div for AST #3835
Conversation
876165a
to
7d17549
Compare
Codecov Report
@@ Coverage Diff @@
## master #3835 +/- ##
==========================================
+ Coverage 95.07% 95.14% +0.06%
==========================================
Files 186 186
Lines 18857 18911 +54
==========================================
+ Hits 17928 17992 +64
+ Misses 929 919 -10
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I look quickly, but LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But I'm wondering, do we have to always get a remote tensor to compare with zero? Can't we do that remotely without fetching it?
Yeah indeed that could be a security issue. We could have a remote is_zero ? Like we have a is_none I think |
Description
This is a small cleaning PR
Affected Dependencies
None
How has this been tested?
Checklist