Replicated Sharing Tensor (RST): secret sharing, reconstruction, and linear operations #3856

abogaziah · 2020-07-13T17:35:35Z

Description

This PR will implement the basic operations of the replicative secret sharing scheme in order to be able to implement falcon protocol
for more details: #3852

Checklist

I have followed the Contribution Guidelines and Code of Conduct
I have commented my code following the OpenMined Styleguide
I have labeled this PR with the relevant Type labels
My changes are covered by tests

Milestones:

Secret sharing
Reconstruction
Public and private addition / sub

syft/frameworks/torch/tensors/interpreters/replicative_shared.py

gmuraru · 2020-07-26T21:07:20Z

@abogaziah I removed some points from this task and created other issues for each one individually.
They can be seen in the FALCON Milestone

syft/frameworks/torch/tensors/interpreters/replicative_shared.py

gmuraru · 2020-08-02T14:45:25Z

syft/frameworks/torch/tensors/interpreters/native.py

@@ -909,6 +909,11 @@ def share(
            requires_grad (bool): Should we add AutogradTensor to allow gradient computation,
                default is False.
        """
+        if protocol == "falcon":
+            shared_tensor = syft.ReplicatedSharingTensor(owner=self.owner).share_secret(


Q: I am thinking if we can keep a dict for those.
Like:

"falcon": syft.ReplicatedSharingTensor, "snn" : syft.AdditiveSharingTensor }

what would be the use-case of that dict? I don't get it

Dict are better to dynamically add options if needed, and are faster to access instead of if / else-ing on all optiosn

@abogaziah are you making the changes in this PR or we can create a subsequent ticket to do the changes in another issue (we can also mark it as good first issue :D)

I think it needs to be done later, because sharing doesn't work the same way in both cases for now, (AST is more complex) maybe we should do that after refactoring AST

Sounds good! There is also some refacto going on in the AST file in #3924 :)

LaRiffle · 2020-08-03T19:40:15Z

syft/frameworks/torch/tensors/interpreters/replicated_shared.py

+            workers = [syft.hook.local_worker] + workers
+        return workers
+
+    def generate_shares(self, plain_text, number_of_shares=3):


I recommend taking example on

PySyft/syft/frameworks/torch/tensors/interpreters/additive_shared.py

Line 334 in 4518a44

def generate_shares(self, secret, n_workers, random_type):

i.e. remove the noise you've added to the next share instead of removing the sum of all on the last share

@LaRiffle What is the difference? in other words, why would you choose this over that?

ping @LaRiffle

I did, I'm looking at how crypten handles it

gmuraru · 2020-08-04T10:11:11Z

I think it looks great as a first PR that enables us to use RSS.
What I think we should implement more is - have the possibility to do operations using "+", "-", etc (I do not know if that is possible for the moment) - There might be needed some @overloaded work

abogaziah · 2020-08-04T10:46:47Z

@gmuraru done :)

gmuraru

It looks good for me! Probably we will end up iterating over this code, but I think that is perfect!

initialized replicated sharing tensor

b9d4638

abogaziah requested a review from a team July 13, 2020 17:37

abogaziah added 2 commits July 13, 2020 20:52

removed crypto provider for now

eb23ed0

added reconstruction implementation and sharing from native tensor

490be20

abogaziah changed the title ~~Falcon basic operation~~ [WIP] Falcon Basic Operation (Replicative sharing scheme) Jul 14, 2020

cleaning

3cbaf4f

abogaziah changed the title ~~[WIP] Falcon Basic Operation (Replicative sharing scheme)~~ [WIP] Falcon Basic Operation (Replicated sharing scheme) Jul 14, 2020

cleaning

9ea4b09

gmuraru reviewed Jul 14, 2020

View reviewed changes

syft/frameworks/torch/tensors/interpreters/replicative_shared.py Outdated Show resolved Hide resolved

cleaning

b7a297c

gmuraru reviewed Jul 15, 2020

View reviewed changes

syft/frameworks/torch/tensors/interpreters/replicative_shared.py Outdated Show resolved Hide resolved

added more tests

ebfaf60

gmuraru linked an issue Jul 16, 2020 that may be closed by this pull request

Falcon: RSS Tensor #3862

Closed

abogaziah added 3 commits July 16, 2020 14:53

added private sharing

4cd8155

added public addetion and general addetion

6fc34c1

added subtraction

fe43b12

abogaziah requested a review from gmuraru July 19, 2020 12:34

This comment has been minimized.

Sign in to view

abogaziah added 2 commits July 19, 2020 16:43

added negative results and refactors

ea9e1a8

fix mod_to_real and switch priavte public

e6d47cb

abogaziah linked an issue Jul 19, 2020 that may be closed by this pull request

FALCON: Basic Operations #3852

Closed

3 tasks

cleaning

6f6e3f8

gmuraru added this to the Falcon Implementation milestone Jul 23, 2020

abogaziah added 6 commits July 29, 2020 16:22

communication rounds optimization

610fe17

more communication rounds optimization

dfc420a

cleaning

6d05c16

added edge cases to tests

13a21d2

cleaning

4fa370f

more cleaning

6107a29

abogaziah added 2 commits July 29, 2020 19:04

even more cleaning

554fddf

even more cleaning

0d98d4d

abogaziah modified the milestones: FALCON Implementation, Replicated Sharing Tensor (RST) Implementation Aug 2, 2020

This was unlinked from issues Aug 2, 2020

FALCON: Basic Operations #3852

Closed

Falcon: RSS Tensor #3862

Closed

This was unlinked from issues Aug 2, 2020

Replicated Sharing Tensor (RST): Correlated Randomness #3898

Closed

Replicated Sharing Tensor (RST): Multiplication of shared values #3900

Closed

abogaziah changed the title ~~[WIP] Falcon Basic Operation (Replicated sharing scheme)~~ Replicated Sharing Tensor (RST): secret sharing, reconstruction, and linear operations Aug 2, 2020

abogaziah added Status: Completed ✔️ Finished with all expected deliverables Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes labels Aug 2, 2020

abogaziah marked this pull request as ready for review August 2, 2020 11:48

gmuraru requested changes Aug 2, 2020

View reviewed changes

gmuraru reviewed Aug 2, 2020

View reviewed changes

arrange workers fix

b111237

abogaziah requested a review from gmuraru August 3, 2020 10:55

LaRiffle reviewed Aug 3, 2020

View reviewed changes

add and sub with operator

7ee8c02

gmuraru approved these changes Aug 6, 2020

View reviewed changes

abogaziah merged commit 00a524c into OpenMined:master Aug 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replicated Sharing Tensor (RST): secret sharing, reconstruction, and linear operations #3856

Replicated Sharing Tensor (RST): secret sharing, reconstruction, and linear operations #3856

abogaziah commented Jul 13, 2020 •

edited

This comment has been minimized.

gmuraru commented Jul 26, 2020

gmuraru Aug 2, 2020

abogaziah Aug 2, 2020

LaRiffle Aug 3, 2020

gmuraru Aug 6, 2020

abogaziah Aug 6, 2020

LaRiffle Aug 6, 2020

LaRiffle Aug 3, 2020

abogaziah Aug 3, 2020 •

edited

gmuraru Aug 6, 2020

abogaziah Aug 6, 2020

gmuraru commented Aug 4, 2020

abogaziah commented Aug 4, 2020

gmuraru left a comment

Replicated Sharing Tensor (RST): secret sharing, reconstruction, and linear operations #3856

Replicated Sharing Tensor (RST): secret sharing, reconstruction, and linear operations #3856

Conversation

abogaziah commented Jul 13, 2020 • edited

Description

Checklist

This comment has been minimized.

gmuraru commented Jul 26, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abogaziah Aug 3, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gmuraru commented Aug 4, 2020

abogaziah commented Aug 4, 2020

gmuraru left a comment

Choose a reason for hiding this comment

abogaziah commented Jul 13, 2020 •

edited

abogaziah Aug 3, 2020 •

edited