Add BatchNorm to AdditiveSharingTensor #3889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LaRiffle
added
Type: New Feature ➕
Codecov Report
@@ Coverage Diff @@
## master #3889 +/- ##
=======================================
Coverage 94.98% 94.99%
=======================================
Files 186 186
Lines 19075 19122 +47
=======================================
+ Hits 18119 18164 +45
- Misses 956 958 +2
|
youben11
approved these changes
Jul 23, 2020
Comment on lines
+70
to
+76
| for i in range(80): | ||
| if x is not None: | ||
| y = C + 1 - var * (x * x) | ||
| x = y * x / C | ||
| else: | ||
| y = C + 1 - var | ||
| x = y / C |
There was a problem hiding this comment.
Why not executing the else outside, and removing condition in the for loop, since it's 1 vs 79 times.
There was a problem hiding this comment.
I agree, however we have 80 for bad reason, in the near future we'll have 3 to 5 iterations :)
I'm waiting for the FALCON team to do this :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Batchnorm and tests
Fix a bug in .var() for evaluation on a specific dim
NOTE This implem will be improved with the current work on FALCON
Checklist