RNS variant multiplication operation for FV scheme. #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rav1kantsingh
added
the
Type: Improvement 📈
|
I have completed the required code for the operation but the result is not correct yet😭. I have added some deepcopy's till debugging. so will remove the redundant deepcopy's after everything starts working properly... |
rav1kantsingh
force-pushed
the
rns-multiplication
branch
from
d2efbd6
to
8f00f6e
Compare
rav1kantsingh
changed the title
Codecov Report
@@ Coverage Diff @@
## master #3893 +/- ##
==========================================
- Coverage 95.07% 94.94% -0.14%
==========================================
Files 186 199 +13
Lines 18868 20247 +1379
==========================================
+ Hits 17939 19223 +1284
- Misses 929 1024 +95
|
youben11
approved these changes
Jul 27, 2020
| @@ -252,55 +250,100 @@ def _mul_cipher_cipher(self, ct1, ct2): | |||
| A Ciphertext object with a value equivalent to the result of the product of two | |||
| operands. | |||
| """ | |||
| ct1, ct2 = ct1.data, ct2.data | |||
| ct1, ct2 = copy.deepcopy(ct1.data), copy.deepcopy(ct2.data) | |||
There was a problem hiding this comment.
is this deepcopy still needed?
rav1kantsingh
force-pushed
the
rns-multiplication
branch
from
881c960
to
96cb2f2
Compare
youben11
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Multiplication operation for FV scheme using RNS variant. The current implementation of a multiplication operation is not performing well during relinearization operation. So updating the operation with the RNS variant.
Affected Dependencies
None
How has this been tested?
Tests already present for multiplication operation but added tests for internal methods.
Checklist