Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve implementation of max and argmax #3895

Merged
merged 5 commits into from
Jul 31, 2020
Merged

Improve implementation of max and argmax #3895

merged 5 commits into from
Jul 31, 2020

Conversation

LaRiffle
Copy link
Contributor

@LaRiffle LaRiffle commented Jul 23, 2020 •
edited

Description

This improves implementation of max and argmax, tests are improved as well

Checklist

@LaRiffle LaRiffle added Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint Status: Blocked ✖️ Cannot work on this because of some other incomplete work Severity: 3 - Medium 😒 Does not cause a failure, impair usability, or interfere with the system labels Jul 23, 2020
@codecov
Copy link

codecov bot commented Jul 30, 2020 •
edited

Codecov Report

Merging #3895 into master will decrease coverage by 0.18%.
The diff coverage is 98.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3895      +/-   ##
==========================================
- Coverage   94.99%   94.80%   -0.19%     
==========================================
  Files         186      200      +14     
  Lines       19122    20313    +1191     
==========================================
+ Hits        18164    19258    +1094     
- Misses        958     1055      +97
Impacted Files Coverage Δ
...orks/torch/tensors/interpreters/additive_shared.py 92.78% <97.77%> (+0.42%) ⬆️
...frameworks/torch/tensors/interpreters/precision.py 97.08% <100.00%> (+0.02%) ⬆️
test/torch/tensors/test_additive_shared.py 100.00% <100.00%> (ø)
syft/frameworks/torch/he/fv/context.py 80.55% <0.00%> (-19.45%) ⬇️
syft/frameworks/torch/he/fv/modulus.py 80.95% <0.00%> (-15.83%) ⬇️
syft/generic/pointers/pointer_plan.py 75.43% <0.00%> (-11.41%) ⬇️
syft/frameworks/torch/mpc/fss.py 91.66% <0.00%> (-7.44%) ⬇️
syft/generic/pointers/object_pointer.py 78.35% <0.00%> (-3.74%) ⬇️
syft/workers/message_handler.py 89.34% <0.00%> (-2.37%) ⬇️
syft/execution/plan.py 94.33% <0.00%> (-0.53%) ⬇️
... and 35 more

@LaRiffle LaRiffle added Priority: 1 - Immediate 🔥 Must be fixed immediately and cannot wait Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes and removed Priority: 2 - High 😰 Should be fixed as quickly as possible, ideally within the current or following sprint Status: Blocked ✖️ Cannot work on this because of some other incomplete work labels Jul 30, 2020
gmuraru
gmuraru reviewed Jul 30, 2020
View reviewed changes
syft/frameworks/torch/tensors/interpreters/additive_shared.py Outdated

# Copy each row (length - 1) times to compare to each other row
a = self.expand(row_length - 1, *self.size())
# print(a)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Remove print

youben11
youben11 approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LaRiffle LaRiffle merged commit 8ae5180 into master Jul 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the ryffel/max branch July 31, 2020 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuraru gmuraru gmuraru left review comments

@youben11 youben11 youben11 approved these changes

Assignees
No one assigned
Labels
Priority: 1 - Immediate 🔥 Must be fixed immediately and cannot wait Severity: 3 - Medium 😒 Does not cause a failure, impair usability, or interfere with the system Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
Function Secret Sharing Integration
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LaRiffle @gmuraru @youben11