Added functionality to launch PyGrid network and nodes upon creation of a cluster #3896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
Codecov Report
@@ Coverage Diff @@
## master #3896 +/- ##
==========================================
- Coverage 94.94% 94.80% -0.14%
==========================================
Files 197 200 +3
Lines 19944 20528 +584
==========================================
+ Hits 18936 19462 +526
- Misses 1008 1066 +58
|
monuelo
suggested changes
Aug 5, 2020
monuelo
approved these changes
Aug 6, 2020
| apt-get -y upgrade | ||
| sudo -i bash -c 'pip install notebook==5.7.8' | ||
| sudo -i bash -c 'pip install git+https://github.com/OpenMined/PyGridNode.git' | ||
| sudo -i bash -c 'echo Starting Node {name} \ |
There was a problem hiding this comment.
GridNode Repo is private and archived now, this should be updated to new method for creating nodes from Pygrid
There was a problem hiding this comment.
Now as the refactoring has completed, I will update it to the new methods shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have added startup-scripts and other necessary changes which will enable the autoscale API to automatically launch PyGrid servers(network and nodes). Now using the autoscale API can launch PyGird cluster(1 network + N nodes) with one function call or create a PyGrid network and add PyGrid nodes to it one at a time as per the requirement.
I have also added tests and an example tutorial training script for the demonstration of the same.
@hericlesme
Issue #3099
Affected Dependencies
None (New Feature)
How has this been tested?
Checklist