Refacto various little thing #3943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3943 +/- ##
==========================================
- Coverage 94.94% 94.85% -0.10%
==========================================
Files 197 200 +3
Lines 19944 20528 +584
==========================================
+ Hits 18936 19472 +536
- Misses 1008 1056 +48
|
gmuraru
reviewed
Aug 6, 2020
| @@ -75,6 +76,13 @@ def apply_no_compression(decompressed_input_bin) -> tuple: | |||
| return decompressed_input_bin, NO_COMPRESSION | |||
|
|
|||
|
|
|||
| scheme_to_compression = { | |||
There was a problem hiding this comment.
Q: Could we move those default values as the first thing in the file (before function definitions)
There was a problem hiding this comment.
@gmuraru I wish I could but I need the functions to be defined first before I add them to the dict
gmuraru
reviewed
Aug 6, 2020
| @@ -75,6 +76,13 @@ def apply_no_compression(decompressed_input_bin) -> tuple: | |||
| return decompressed_input_bin, NO_COMPRESSION | |||
|
|
|||
|
|
|||
| scheme_to_compression = { | |||
| NO_COMPRESSION: apply_no_compression, | |||
| LZ4: apply_lz4_compression, | |||
There was a problem hiding this comment.
I could not add a comment on that line.
At line 72, there is specified LZ4, but it should have been NO_COMPRESSION.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These are remaining few fixes and updates
Checklist