Add argmin and min method in AST
#3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3961 +/- ##
==========================================
+ Coverage 94.85% 94.87% +0.01%
==========================================
Files 202 202
Lines 20735 20801 +66
==========================================
+ Hits 19669 19734 +65
- Misses 1066 1067 +1
|
gmuraru
reviewed
Aug 8, 2020
| keepdim: keep the dimension of the tensor when dim is not None | ||
| algorithm: method to compute the minimum | ||
| Returns: | ||
| the max of the tensor self |
There was a problem hiding this comment.
Oh, it's my mistake. Thank You
gmuraru
reviewed
Aug 8, 2020
|
|
||
| t = torch.tensor([3, 1.0, 2]) | ||
| x = t.fix_prec().share(*args, **kwargs) | ||
| print(x.argmin) |
gmuraru
reviewed
Aug 8, 2020
| t = torch.tensor([[1, 2.0, 4], [3, 1.0, 2.0]]) | ||
| x = t.fix_prec().share(*args, **kwargs) | ||
| ids = x.argmin(dim=1).get().float_prec() | ||
| assert (ids.long() == torch.argmin(t, dim=1)).all() |
There was a problem hiding this comment.
Q: Could you also add a test with one hot and keepdim?
|
LGTM! |
gmuraru
approved these changes
Aug 9, 2020
|
Thank you for your review! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I add
minandargmin.Affected Dependencies
List any dependencies that are required for this change.
How has this been tested?
Checklist