Update FV scheme to use context chain instead of single context object #3962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rav1kantsingh
added
the
Type: Improvement 📈
rav1kantsingh
changed the title
youben11
suggested changes
Aug 9, 2020
Comment on lines
66
to
70
| Args: | ||
| param: An EncryptionParams object with polynomial modulus, coefficient modulus and | ||
| plain modulus set. | ||
| prev_context_id: Id of the previous ContextData object in context chain. | ||
| next_context_id: Id of the next ContextData object in context chain. |
There was a problem hiding this comment.
Shouldn't the Args be in the init method?
There was a problem hiding this comment.
Okay, I will put the whole doc component inside init
|
|
||
| else: | ||
| raise ValueError("key for encryption is not valid") | ||
|
|
||
| def _encrypt(self, message, is_asymmetric): | ||
| def _encrypt(self, message, param_id, is_asymmetric): |
Comment on lines
-38
to
-39
| if not is_initialized: | ||
| self._secret_key = SecretKey(sample_poly_ternary(param)) |
There was a problem hiding this comment.
is_initialized is no more needed because if the context is not set up it will throw the error while validation in context class. So the secret key can be created using context(anytime with validated context object). And for other keys, I will check for the None value of secret key.
| @@ -109,7 +109,7 @@ def sample_poly_uniform(param): | |||
| return result | |||
|
|
|||
|
|
|||
| def encrypt_asymmetric(context, public_key): | |||
| def encrypt_asymmetric(context, param_id, public_key): | |||
|
|
||
|
|
||
| def encrypt_symmetric(context, secret_key): | ||
| def encrypt_symmetric(context, param_id, secret_key): |
Codecov Report
@@ Coverage Diff @@
## master #3962 +/- ##
==========================================
+ Coverage 94.85% 94.88% +0.03%
==========================================
Files 202 202
Lines 20735 20879 +144
==========================================
+ Hits 19669 19812 +143
- Misses 1066 1067 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Relinearization operation, we need to perform modulus switching which requires the context chain to have context object with different coefficient modulus value.
Affected Dependencies
None
How has this been tested?
All tests for components passing
Checklist