Error message if non integer value used with BFV scheme #4042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rav1kantsingh
added
the
Priority: 3 - Medium 😒
youben11
suggested changes
Aug 20, 2020
| @@ -41,7 +41,8 @@ def encode(self, value): | |||
| Returns: | |||
| A PlainText object containing the integer value. | |||
| """ | |||
|
|
|||
| if not isinstance(value, int): | |||
| raise ValueError(f"BFV scheme only works with integer values, whereas provided {value}") | |||
There was a problem hiding this comment.
Maybe show the type of the value instead of the value itself?
Codecov Report
@@ Coverage Diff @@
## master #4042 +/- ##
==========================================
- Coverage 94.78% 94.77% -0.01%
==========================================
Files 205 205
Lines 21182 21184 +2
==========================================
Hits 20077 20077
- Misses 1105 1107 +2
|
youben11
approved these changes
Aug 26, 2020
rav1kantsingh
added a commit
to rav1kantsingh/PySyft
that referenced
this pull request
Oct 29, 2020
* Error message if non integer values given to BFV scheme * error message update; show type instead of value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just added an error message for the case when the bfv scheme is used with non-interger values.
Affected Dependencies
None
Checklist