Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simplify and detail in DataCentricFLClient #4056

Merged

Conversation

Nilanshrajput
Copy link
Contributor

Description

a better method for serialization

How has this been tested?

Checklist

@Nilanshrajput Nilanshrajput requested review from a team as code owners August 20, 2020 20:56
@Nilanshrajput Nilanshrajput changed the title Update simplify and detail in datacentclient Update simplify and detail in DataCentricFLClient Aug 20, 2020
@Nilanshrajput Nilanshrajput added Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor labels Aug 20, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #4056 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
- Coverage   94.78%   94.76%   -0.02%     
==========================================
  Files         205      205              
  Lines       21187    21187              
==========================================
- Hits        20082    20078       -4     
- Misses       1105     1109       +4     
Impacted Files Coverage Δ
syft/execution/plan.py 94.33% <0.00%> (-0.57%) ⬇️
syft/serde/msgpack/serde.py 91.11% <0.00%> (-0.56%) ⬇️
...ft/frameworks/torch/tensors/interpreters/native.py 91.27% <0.00%> (-0.22%) ⬇️

@cereallarceny cereallarceny merged commit afadb6b into OpenMined:master Aug 21, 2020
rav1kantsingh pushed a commit to rav1kantsingh/PySyft that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes Type: Improvement 📈 Minor improvements not introducing a new feature or requiring a major refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants