New tensor type for FV scheme #4061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rav1kantsingh
added
Type: New Feature ➕
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
rav1kantsingh
force-pushed
the
fv-tensor
branch
2 times, most recently
from
1593910
to
32a2581
Compare
rav1kantsingh
force-pushed
the
fv-tensor
branch
from
32a2581
to
35163a9
Compare
youben11
reviewed
Oct 31, 2020
Comment on lines
58
to
75
| def __add__(self, *args, **kwargs): | ||
| self.prepareEvaluator() | ||
|
|
||
| if not args[0].shape == self.child.shape: | ||
| raise ValueError( | ||
| f"Cannot add tensors with different shape {args[0].shape} , {self.child.shape}" | ||
| ) | ||
|
|
||
| args = args[0].flatten().tolist() | ||
|
|
||
| # if integer values; transform it to plaintext | ||
| if isinstance(args[0], int): | ||
| args = [self.encoder.encode(x) for x in args] | ||
|
|
||
| child = self.child.flatten().tolist() | ||
|
|
||
| data = [self.evaluator.add(x, y) for x, y in zip(child, args)] | ||
| data = np.array(data).reshape(self.child.shape) |
There was a problem hiding this comment.
Have you tried to implement the __radd__, __rsub__ methods so that it also can operate when it's the right operand. However, I'm not sure this is how we should do it in PySyft.
Comment on lines
1162
to
1163
| # Homomorphic Encryption using private key; if private key available prefer it. | ||
| x_encrypted.child.encrypt(private_key, context) |
| Tensors, so compared to the @overloaded.method, you see | ||
| that the @overloaded.module does not hook the arguments. | ||
| """ | ||
| pass |
There was a problem hiding this comment.
Shouldn't this be implemented with the other operations?
|
Currently, the tests are failling here: You need to also add serialization/deserialize tests. |
gmuraru
reviewed
Nov 5, 2020
| @overloaded.method | ||
| def add(self, _self, *args, **kwargs): | ||
| """ | ||
| Here is an example of how to use the @overloaded.method decorator. To see |
There was a problem hiding this comment.
MAYBE: Need to update the commnets :D
gmuraru
reviewed
Nov 5, 2020
| obj.child = data | ||
| return obj | ||
|
|
||
| def mm(self, *args, **kwargs): |
There was a problem hiding this comment.
Q: Can't we use also overload this?
gmuraru
reviewed
Nov 5, 2020
| self.evaluator = None | ||
|
|
||
| def encrypt(self, key, context): | ||
| self.context = context |
There was a problem hiding this comment.
Q: Shouldn't we populate self and return self?
gmuraru
reviewed
Nov 5, 2020
| inputs = self.child.flatten().tolist() | ||
| new_child = [self.encryptor.encrypt(self.encoder.encode(x)) for x in inputs] | ||
|
|
||
| data = np.array(new_child).reshape(self.child.shape) |
There was a problem hiding this comment.
Q: It is necessary to be np.array can't it be tensor?
|
@IamRavikantSingh I changed this to point to syft_0.2.x |
rav1kantsingh
force-pushed
the
fv-tensor
branch
from
62beac7
to
403d9a0
Compare
rav1kantsingh
force-pushed
the
fv-tensor
branch
from
403d9a0
to
fdb0188
Compare
1. Add inplace decryption 2. Fix operations on ciphertext: working: th.add(), a.add(b), a + b (same for sub, mul). matrix multiplication only working with a.mm(b) yet.
rav1kantsingh
force-pushed
the
fv-tensor
branch
from
686e59d
to
9bfa9db
Compare
|
Hi! 0.2.x hit EOL, closing this as we no longer support it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #3710
Creating a new tensor type for supporting the FV homomorphic encryption scheme written internally in PySyft.
might remain as a draft for some time because it still needs several changes to make it fully functional.
Affected Dependencies
will update it.
How has this been tested?
will update it
Checklist