Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scripts, graphs for benchmarking AST operations #4064

Merged
merged 6 commits into from
Aug 25, 2020
Merged

Added scripts, graphs for benchmarking AST operations #4064

merged 6 commits into from
Aug 25, 2020

Conversation

aanurraj
Copy link
Member

@aanurraj aanurraj commented Aug 22, 2020

Description

Scripts and Graphs are added for benchmarking AST operation based on two currently available protocols (fss, snn).
currently added scripts and graphs are added for:-

  • share_get

  • max_pool2d

  • avg_pool2d

  • batch_norm

Improvement suggestions are welcomed :)

This PR Partially fixes #4000

Affected Dependencies

None

How has this been tested?

  • This addition doest requires an additional test but an average of 10 timestamps have been computed to get an accurate result.
  • Benchmark graphs may be different for different system specifications on which the scripts are run though they should show a similar trend.

Checklist

-added one more worker in worker_initilization.py
-added benchmark_share_get_plot's data in benchmark_sample_data.py
-added functions
-fiexed typos
@aanurraj aanurraj changed the title Added Scrips, Graphs for Benchmarking AST operations Added scripts, graphs for benchmarking AST operations Aug 22, 2020
@codecov
Copy link

codecov bot commented Aug 22, 2020

Codecov Report

Merging #4064 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4064      +/-   ##
==========================================
- Coverage   94.78%   94.77%   -0.01%     
==========================================
  Files         205      205              
  Lines       21195    21195              
==========================================
- Hits        20089    20088       -1     
- Misses       1106     1107       +1     
Impacted Files Coverage Δ
...ft/frameworks/torch/tensors/interpreters/native.py 91.27% <0.00%> (-0.22%) ⬇️

Copy link
Member

@Syzygianinfern0 Syzygianinfern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion: Could you remove unnecessary line-breaks 🙈

@aanurraj
Copy link
Member Author

Just a suggestion: Could you remove unnecessary line-breaks 🙈

Sure :)

@marload
Copy link
Member

marload commented Aug 24, 2020

Could you resolve conflict?

@aanurraj
Copy link
Member Author

Could you resolve conflict?

done :)

@iamtrask
Copy link
Member

This is a very nice contribution!

@aanurraj
Copy link
Member Author

This is a very nice contribution!

Thanks, it really feels amazing to get this from you!

Copy link
Member

@marload marload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@marload marload merged commit ebe08b5 into OpenMined:master Aug 25, 2020
rav1kantsingh pushed a commit to rav1kantsingh/PySyft that referenced this pull request Oct 29, 2020
* added benchmark_share_get_plot function

-added one more worker in worker_initilization.py
-added benchmark_share_get_plot's data in benchmark_sample_data.py

* add benchmark_max_pool2d function

-added functions
-fiexed typos

* added benchmark_avg_pool2d function

* added benchmark_batch_norm_plot function

* updated benchmark_sample_data.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Benchmark AST operations
4 participants