Added support for negative numbers in reciprocal method #4048 #4065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4065 +/- ##
=======================================
Coverage 94.77% 94.78%
=======================================
Files 205 205
Lines 21187 21195 +8
=======================================
+ Hits 20081 20089 +8
Misses 1106 1106
|
marload
reviewed
Aug 22, 2020
| @@ -468,7 +468,7 @@ def matmul(self, *args, **kwargs): | |||
| __matmul__ = matmul | |||
| mm = matmul | |||
|
|
|||
| def reciprocal(self, method="NR", nr_iters=10): | |||
| def reciprocal(self, method="division", nr_iters=10): | |||
There was a problem hiding this comment.
In general, NR is much faster than division. Is there a reason for changing this? 😄
There was a problem hiding this comment.
#4036 (comment)... I saw this and made a change. I think now keeping it as NR should not be a problem.
| pos = sgn | ||
| neg = sgn - 1 | ||
| sgn = pos + neg | ||
| self = sgn * self |
There was a problem hiding this comment.
This part duplicates many parts with NR. Can you remove this duplication? 😎
|
Can you have a look again @marload ? I have added a modulus and signum function instead |
|
@marload it showing that I still need a review from openmined/cryptography! So that means anyone from that team can review right? |
Comment on lines
+511
to
+512
| result = 2 * result - result * result * new_self | ||
| return result * self.signum() |
Syzygianinfern0
suggested changes
Aug 23, 2020
Syzygianinfern0
approved these changes
Aug 23, 2020
rav1kantsingh
pushed a commit
to rav1kantsingh/PySyft
that referenced
this pull request
Oct 29, 2020
* Support for negative numbers * negative numbers support * Negative numbers support for reciprocal * negative nums support for reciprocal method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #4048
Added support for negative numbers when use different methods in Reciprocal.
Uses a signum function to achieve this
Suggestions are welcome!
Affected Dependencies
How has this been tested?
Checklist