Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black2b hash function to generate param_id for bfv scheme #4509

Merged
merged 1 commit into from
Sep 6, 2020

Conversation

rav1kantsingh
Copy link
Member

Description

Update the param id generation for generating hash ids for context object in context chain.
Using black2b hash from hashlib.
for details: https://blake2.net/

Affected Dependencies

FV module

How has this been tested?

All tests should pass

Checklist

@rav1kantsingh rav1kantsingh added the Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes label Aug 31, 2020
@rav1kantsingh rav1kantsingh added this to the BFV Tensor in Python milestone Aug 31, 2020
@rav1kantsingh rav1kantsingh requested a review from a team as a code owner August 31, 2020 17:31
@rav1kantsingh rav1kantsingh changed the title Add black2b hash to generate param_id for bfv scheme Add black2b hash function to generate param_id for bfv scheme Aug 31, 2020
@codecov
Copy link

codecov bot commented Aug 31, 2020

Codecov Report

Merging #4509 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4509      +/-   ##
==========================================
- Coverage   94.81%   94.79%   -0.02%     
==========================================
  Files         209      209              
  Lines       21357    21360       +3     
==========================================
  Hits        20249    20249              
- Misses       1108     1111       +3     
Impacted Files Coverage Δ
syft/frameworks/torch/he/fv/encryption_params.py 89.47% <100.00%> (+1.97%) ⬆️
syft/execution/plan.py 94.33% <0.00%> (-0.57%) ⬇️
...ft/frameworks/torch/tensors/interpreters/native.py 91.27% <0.00%> (-0.22%) ⬇️

Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youben11 youben11 merged commit b82e4d0 into OpenMined:master Sep 6, 2020
rav1kantsingh added a commit to rav1kantsingh/PySyft that referenced this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review Needed 🙋 This needs someone to approve, deny, comment, or request changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants